Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tags trigger; bump MSRV to 1.65 #1842

Merged
merged 2 commits into from
Jun 24, 2023
Merged

Conversation

infogulch
Copy link
Contributor

@infogulch infogulch commented Jun 24, 2023

Changes the CI trigger to automatically create release when a tag that matches v* is pushed to the repo.

Also bumps MSRV to 1.65, because the version of rug in cargo.lock was increased to 1.19, which only supports rust 1.65 and newer. This was causing the build to fail.

@infogulch infogulch changed the title Fix tags trigger Fix tags trigger; bump MSRV to 1.65 Jun 24, 2023
@infogulch
Copy link
Contributor Author

@mthom, I see that you prefer to make big changes on a separate long-term development branch, and then periodically merge it into master. I think this is fine and you should develop however you like. But unfortunately this workflow doesn't work with the CI system very well, so CI won't help you catch issues like the one above where bumping rug to 1.19 requires changing scryer's MSRV to 1.65 mentioned above.

Maybe consider opening a PR to merge the working branch into master, and just leave it there while you work. (Mark it as draft or wip if you want to communicate that status.) That would trigger the CI build to run whenever you push changes which would give you a pulse on how your changes would affect the builds and tests across the target supported environments.

@mthom
Copy link
Owner

mthom commented Jun 24, 2023

thanks @infogulch, I'll do that from now on.

@mthom mthom merged commit 59766e2 into mthom:master Jun 24, 2023
@infogulch infogulch deleted the release-on-tag branch September 9, 2023 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants